-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Create dedicated panel for home dashboard #27861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| const config = await generateLovelaceDashboardStrategy( | ||
| HOME_LOVELACE_CONFIG, | ||
| this.hass | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some error handling here or it will fail silently. I had this issue on the energy dashboard somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the strategies fail silently, we should fix that. I will do error handling in a future PR.
silamon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations are still missing in the alert.
| title: "Edit mode not available", | ||
| text: "The Home panel does not support edit mode.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not translated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that will change for the release. We will provide a basic editor to edit favorite entities. I added a comment in the code for that 👍
Proposed change
This PR extracts duplicate view navigation logic from hui-root and panel components into a new reusable
hui-lovelacecomponent so we can introduce a new home panel with multiple views.Also the following panels has been migrated : security, light and climate.
This new panel will need a core change to register
homepanel on the frontend integration (home-assistant/core#156269).Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: