Skip to content

Conversation

@balloob
Copy link
Member

@balloob balloob commented Nov 30, 2025

Breaking change

Proposed change

Replace direct customElements.define() calls with the @customElement decorator from lit/decorators across 32 files.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:


Note

Replaces direct customElements.define calls with Lit @customElement decorators across components, dialogs, panels, Lovelace cards/views, and utilities; updates imports accordingly.

  • Refactor: Element registration
    • Replace customElements.define(...) with Lit @customElement(...) across:
      • Components: state-history-chart-line, state-badge, ha-entity-marker, notification-manager, ha-init-page.
      • Dialogs/Controls: more-info-* (camera, climate, group, humidifier), dialog-* (calendar event detail, area/floor/person/zone details, schedule block info, manage cloudhook, system log detail, home/zone detail).
      • Panels/Views: ha-panel-history, ha-panel-custom, Lovelace views (hui-masonry-view, hui-panel-view, hui-sidebar-view).
      • Lovelace cards/elements: hui-grid-card, hui-vertical-stack-card, hui-conditional-element.
      • Directive/Utility: action-handler directive element.
    • Update imports to include customElement from lit/decorators and remove trailing manual registrations.

Written by Cursor Bugbot for commit 3051828. This will update automatically on new commits. Configure here.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claude

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft November 30, 2025 03:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@balloob balloob force-pushed the claude/add-custom-element-decorators-01Q6osgnboYjrHXNJYfdZUsE branch from 141e302 to 99c752e Compare November 30, 2025 04:06
@balloob balloob marked this pull request as ready for review November 30, 2025 04:06
@silamon silamon merged commit 28a89ff into dev Dec 1, 2025
16 checks passed
@silamon silamon deleted the claude/add-custom-element-decorators-01Q6osgnboYjrHXNJYfdZUsE branch December 1, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants