Flavor getters #177
Merged
Flavor getters #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huandu
requested changes
Oct 31, 2024
Owner
huandu
left a comment
huandu
left a comment
There was a problem hiding this comment.
Besides builders updated in this PR, we can also add Flavor() Flavor in Build interface and implement this new method in compiledBuilder and flavoredBuilder in ./builder.go.
createtable.go
Outdated
| return | ||
| } | ||
|
|
||
| func (ctb *CreateTableBuilder) GetFlavor() Flavor { |
Owner
There was a problem hiding this comment.
The method name should be Flavor rather than GetFlavor according to Effective Go. And don't forget to add comment to describe this method.
createtable_test.go
Outdated
| func TestCreateTableGetFlavor(t *testing.T) { | ||
| a := assert.New(t) | ||
| ctb := newCreateTableBuilder() | ||
| postgresFlavor := PostgreSQL |
Owner
There was a problem hiding this comment.
It's not necessary to assign a const to a local variable. Doing this will make the test code less readable. It's recommended to use const in assertions directly.
Owner
|
Thanks for your contribution! I sent you several review comments. Feel free to discuss with me if you have any thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.