Support both huggingface_hub v0.x
and v1.x
#12389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to huggingface/huggingface_hub#3340 huggingface/transformers#40889
With the upcoming huggingface_hub
v1.0
release, we don't need many changes indiffusers
. That's why it will be possible to support both 0.x and 1.x versions -and let users decide which one suits them better-. The main difference is the use ofhttpx
instead ofrequests
which requires to catch different errors compared to before.In this PR I did not work on moving
diffusers
completely out ofrequests
in favor ofhttpx
. It would still be good to do it in ~2 months once the transformers v5 + hfh v1 will have been released. Doing that will definitely harmonize the HTTP backend but will require to remove hfh v0.x support (hence why it's best to wait until 1.0 is properly released).Note that in this PR the CI will still be triggered on
huggingface_hub
v.0.x (and should pass). I opened #12384 in parallel that has more changes to trigger on v1.0 (requires some tricky stuff because of release candidates).Plan is to review/merge this PR and close #12384 afterwards.