Skip to content

[Tasks] add text-to-video JSON spec + Inference client #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 23, 2025
Merged

[Tasks] add text-to-video JSON spec + Inference client #1099

merged 12 commits into from
Jan 23, 2025

Conversation

@SBrandeis
Copy link
Contributor

@SBrandeis SBrandeis commented Jan 13, 2025 •
edited
Loading

TL;DR

  • Add input / output JSON schema specs for the text-to-video task
  • Use generated Typescript interfaces to add support for this in the inference client
  • Add a few text-to-video models to the list of supported models for Fal.ai and Replicate

@SBrandeis SBrandeis force-pushed the tasks/spec-text-to-video branch from e248c6e to 9852cd9 Compare January 21, 2025 12:14
julien-c
julien-c reviewed Jan 21, 2025
View reviewed changes
packages/inference/src/tasks/cv/textToImage.ts
...omit(args, ["inputs", "parameters"]),
...(args.provider !== "replicate" ? { response_format: "base64" } : undefined),
}
: args;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed this is maybe better 👍

@SBrandeis SBrandeis marked this pull request as ready for review January 21, 2025 13:12
Wauplin
Wauplin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (mostly reviewed things under ./src/tasks/text-to-video/)

@SBrandeis SBrandeis merged commit a3f6ecd into main Jan 23, 2025
5 checks passed
@SBrandeis SBrandeis deleted the tasks/spec-text-to-video branch January 23, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-c julien-c julien-c approved these changes

@Wauplin Wauplin Wauplin approved these changes

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

@coyotte508 coyotte508 Awaiting requested review from coyotte508

@hanouticelina hanouticelina Awaiting requested review from hanouticelina hanouticelina is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SBrandeis @julien-c @Wauplin