[Inference] Generate binary types as Blob and use the generated types in the inference client
#1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Jan 21, 2025
SBrandeis
commented
Jan 21, 2025
| "audio": { | ||
| "description": "The generated audio waveform." | ||
| "description": "The generated audio waveform.", | ||
| "comment": "type=binary" |
There was a problem hiding this comment.
I used this trick to mark a parameter as "binary" (which translates, in the generated Typescript code, to declaring it to be of type Blob)
Generation code: https://github.com/huggingface/huggingface.js/pull/1116/files#diff-3a9454ed7c359e2e0522703d9acf4559f6b10fdd67236692bdd4422dd9c8f472R97-R182
SBrandeis
requested review from
Wauplin,
gary149,
ngxson and
pcuenca
as code owners
SBrandeis
changed the title
Blob and use the generated types in the inference clientBlob and use the generated types in the inference client
julien-c
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
haven't dived in detail but the compatibility plan LGTM @SBrandeis
coyotte508
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
@huggingface/tasksJSON schemas to type the input types of the Inference client