[Inference Providers] feat. Refactor the NovitaTextToVideoTask using the async API. #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor2077
requested review from
SBrandeis,
hanouticelina and
julien-c
as code owners
SBrandeis
reviewed
May 19, 2025
Thanks @SBrandeis , these suggestions are detailed and helpful! |
hanouticelina
added
the
inference-providers
SBrandeis
reviewed
May 22, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SBrandeis
approved these changes
May 22, 2025
There was a problem hiding this comment.
Looks good to me!
Defering to @hanouticelina for a second pair of eyes 👀
Thanks @viktor2077
hanouticelina
approved these changes
May 26, 2025
There was a problem hiding this comment.
Thanks @viktor2077 for the PR, and sorry again for the delay! 🤗
I’ve tested it with direct calls to Novita and everything works as expected.
I also opened a server-side PR to allow GET requests through Hugging Face routing — I’ll merge this as soon as that’s deployed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
NovitaTextToVideoTaskusing the async API, aiming to allow inference with models that may take over 2 minutes to generate results.