-
Notifications
You must be signed in to change notification settings - Fork 521
feat/add baseten provider (js) #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a minor comment regarding overriding default route but otherwise should be fine :)
Note that I did not try the client myself yet.
@Wauplin just fixed, thanks for pointing it out. I tested the integration myself after this change and all tests are still passing. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, (once test comment is addressed :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤗 Let's wait a second pair of eyes on this :)
great thanks @Wauplin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds Baseten as a new inference provider for conversational tasks.
Route: /v1/chat/completions (OpenAI Compatible)
Added tests to
InferenceClient.spec.ts
. Ran tests locally to check they're all passing.