[CLI] Remove [cli] extra
#3451
Merged
[CLI] Remove [cli] extra
#3451
+16
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Thanks!
It doesn't make sense to keep huggingface_hub[cli] only to install shelligham (which is used by typer for the auto-completion feature). Let's put shelligham as a required dependency and remove the cli extra.
Agree 👍
Wauplin
approved these changes
Oct 20, 2025
… into remove-cli-extra
|
failing tests unrelated, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work done to revamp HF cache CLI in #3439, both
hf scan cacheandhf scan deletehave been removed for the v1 release and we completely got rid of the optional dependencyInquirerPy.It doesn't make sense to keep
huggingface_hub[cli]only to installshelligham(which is used by typer for the auto-completion feature). Let's putshellighamas a required dependency and remove thecliextra.