Skip to content

Conversation

@rajatarya
Copy link
Contributor

@rajatarya rajatarya commented Oct 23, 2025

Add hf-xet as a required installation for platforms that report themselves as 'AMD64'.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@rajatarya
Copy link
Contributor Author

Here is the output on a fresh venv on my Windows machine:

C:\Users\rajat\test-platform>uv venv --python C:\Users\rajat\.local\bin\python3.14t.exe
Using CPython 3.14.0 interpreter at: C:\Users\rajat\.local\bin\python3.14t.exe
Creating virtual environment at: .venv
Activate with: .venv\Scripts\activate

C:\Users\rajat\test-platform>.venv\Scripts\activate

(test-platform) C:\Users\rajat\test-platform>uv pip install huggingface_hub
Resolved 13 packages in 368ms
Prepared 1 package in 452ms
Installed 13 packages in 278ms
 + certifi==2025.10.5
 + charset-normalizer==3.4.4
 + colorama==0.4.6
 + filelock==3.20.0
 + fsspec==2025.9.0
 + huggingface-hub==0.36.0
 + idna==3.11
 + packaging==25.0
 + pyyaml==6.0.3
 + requests==2.32.5
 + tqdm==4.67.1
 + typing-extensions==4.15.0
 + urllib3==2.5.0

(test-platform) C:\Users\rajat\test-platform>uv pip freeze
certifi==2025.10.5
charset-normalizer==3.4.4
colorama==0.4.6
filelock==3.20.0
fsspec==2025.9.0
huggingface-hub==0.36.0
idna==3.11
packaging==25.0
pyyaml==6.0.3
requests==2.32.5
tqdm==4.67.1
typing-extensions==4.15.0
urllib3==2.5.0

(test-platform) C:\Users\rajat\test-platform>

Notice: no hf-xet is present

@rajatarya
Copy link
Contributor Author

And installing huggingface_hub from this branch instead, now hf-xet is installed:

C:\Users\rajat\test-platform-AMD64>uv venv --python cpython-3.12.12-windows-x86_64-none
Using CPython 3.12.12
Creating virtual environment at: .venv
Activate with: .venv\Scripts\activate

C:\Users\rajat\test-platform-AMD64>.venv\Scripts\activate

(test-platform-AMD64) C:\Users\rajat\test-platform-AMD64>uv pip install "git+https://github.com/huggingface/huggingface_hub.git@rajatarya/platform_AMD64_win"
Resolved 19 packages in 654ms
Prepared 2 packages in 193ms
Installed 19 packages in 446ms
 + anyio==4.11.0
 + certifi==2025.10.5
 + click==8.3.0
 + colorama==0.4.6
 + filelock==3.20.0
 + fsspec==2025.9.0
 + h11==0.16.0
 + hf-xet==1.1.10
 + httpcore==1.0.9
 + httpx==0.28.1
 + huggingface-hub==1.0.0rc7 (from git+https://github.com/huggingface/huggingface_hub.git@0d8b18fef6749c0f5f3592677c8cd45a5dbd8963)
 + idna==3.11
 + packaging==25.0
 + pyyaml==6.0.3
 + shellingham==1.5.4
 + sniffio==1.3.1
 + tqdm==4.67.1
 + typer-slim==0.20.0
 + typing-extensions==4.15.0

(test-platform-AMD64) C:\Users\rajat\test-platform-AMD64>uv pip freeze
anyio==4.11.0
certifi==2025.10.5
click==8.3.0
colorama==0.4.6
filelock==3.20.0
fsspec==2025.9.0
h11==0.16.0
hf-xet==1.1.10
httpcore==1.0.9
httpx==0.28.1
huggingface-hub @ git+https://github.com/huggingface/huggingface_hub.git@0d8b18fef6749c0f5f3592677c8cd45a5dbd8963
idna==3.11
packaging==25.0
pyyaml==6.0.3
shellingham==1.5.4
sniffio==1.3.1
tqdm==4.67.1
typer-slim==0.20.0
typing-extensions==4.15.0

@rajatarya
Copy link
Contributor Author

This is the output from my Windows machine from platform.machine():

(test-platform-AMD64) C:\Users\rajat\test-platform-AMD64>python
Python 3.12.12 (main, Oct 14 2025, 21:24:50) [MSC v.1944 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> platform.machine()
'AMD64'
>>>

@rajatarya rajatarya changed the title add support for platform.machine()=="ARM64" hf-xet: add support for platform.machine()=="ARM64" Oct 23, 2025
@rajatarya rajatarya marked this pull request as ready for review October 23, 2025 15:05
@rajatarya rajatarya changed the title hf-xet: add support for platform.machine()=="ARM64" hf-xet: add support for platform.machine()=="AMD64" Oct 23, 2025
@Wauplin
Copy link
Contributor

Wauplin commented Oct 23, 2025

Awesome! Thanks @rajatarya :) We'll merge it once I've check the failing CI.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rajatarya!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great news! 👍

@Wauplin Wauplin merged commit 39ebbc0 into main Oct 24, 2025
23 checks passed
@Wauplin Wauplin deleted the rajatarya/platform_AMD64_win branch October 24, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants