Skip to content

Conversation

@Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 7, 2025

Listing user access requests recurrently returns a list. However the backend API is soon to be introducing paginated results due to large number of requests for some repos resulting in memory/cpu peaks (see internal PR).

This PR updates the list_pending_access_requests, list_accepted_access_requests, and list_rejected_access_requests methods to return an iterator instead of a list. This allows us to lazy load requests from paginated results.

⚠️ Warning: this is a breaking change! Not great but hopefully these methods are not much used. Let's proactively contact teams we know are using it.

cc @Kakulukian @Pierrci

@Wauplin Wauplin requested a review from hanouticelina November 7, 2025 13:12
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks

@Wauplin Wauplin merged commit 316db10 into main Nov 7, 2025
24 checks passed
@Wauplin Wauplin deleted the paginated-list-user-access branch November 7, 2025 15:03
@Pierrci
Copy link
Member

Pierrci commented Nov 7, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants