Paginated results when listing user access requests #3535
Merged
+26
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing user access requests recurrently returns a list. However the backend API is soon to be introducing paginated results due to large number of requests for some repos resulting in memory/cpu peaks (see internal PR).
This PR updates the
list_pending_access_requests,list_accepted_access_requests, andlist_rejected_access_requestsmethods to return an iterator instead of a list. This allows us to lazy load requests from paginated results.cc @Kakulukian @Pierrci