Fix cargo install commands for candle with CUDA
#719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cargo install --path router ...` commands for the features `candle-cuda` and `candle-cuda-turing` were using the flag `--no-default-features` that was ignoring the default features in the `text-embeddings-router` being `candle,http,dynamic-linking`, hence the command was failing as `cudarc` requires to have any linking out of `static-linking`, `dynamic-linking` or `dynamic-loading` for the CUDA Libraries, hence when ignoring the `default` features, and just adding `-F http` either the e.g. `-F dynamic-loading` feature was missing or just to only keep the e.g. `-F candle-cuda`, as `dynamic-linking` and `http` are default features already.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
cargo install --path router ...commands in bothREADME.mdanddocs/source/en/local_gpu.mdfor the featurescandle-cudaandcandle-cuda-turing, as those were using the flag--no-default-featuresthat was ignoring the default features in thetext-embeddings-routerbeingcandle,http,dynamic-linking, hence the command was failing ascudarcrequires to have any linking out ofstatic-linking,dynamic-linkingordynamic-loadingfor the CUDA Libraries.Fixes #709
Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil