Skip to content

Conversation

jiqing-feng
Copy link
Contributor

The latest vllm changed the guided_decoding to structured_outputs in this PR 22772. We also need to update this parameter in the vllm client and vllm serve.

Hi @qgallouedec . Would you please review this PR? Thanks!

@kashif
Copy link
Collaborator

kashif commented Sep 22, 2025

we will need to make sure that we require the version of vllm that supports this feature

@jiqing-feng
Copy link
Contributor Author

jiqing-feng commented Sep 22, 2025

we will need to make sure that we require the version of vllm that supports this feature

Sure, we can wait for the vllm release and then update the vllm version in setup in this PR.

@kashif
Copy link
Collaborator

kashif commented Sep 22, 2025

you will need to update this: https://github.com/huggingface/trl/blob/main/setup.cfg#L67

@jiqing-feng
Copy link
Contributor Author

you will need to update this: https://github.com/huggingface/trl/blob/main/setup.cfg#L67

Yes, exactly. I will update it once vllm 10.3.0 released.

Signed-off-by: jiqing-feng <[email protected]>
@qgallouedec
Copy link
Member

for ref: #4122 will pin vLLM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants