Exclude vllm dependencies from dev extra #4229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude
vllm
extra dependencies fromdev
extra, so it is aligned with the behavior before:Before that PR, the
vllm
extra dependencies were not included indev
extra. See:trl/setup.cfg
Lines 76 to 87 in 5291015
This PR updates the
dev
dependencies in thepyproject.toml
file, sovllm
extra dependencies are not included in thedev
extra.Fix #4228.