Skip to content

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Oct 8, 2025

Exclude vllm extra dependencies from dev extra, so it is aligned with the behavior before:

Before that PR, the vllm extra dependencies were not included in dev extra. See:

trl/setup.cfg

Lines 76 to 87 in 5291015

dev =
%(bco)s
%(deepspeed)s
%(judges)s
%(liger)s
%(peft)s
%(quality)s
%(quantization)s
%(scikit)s
%(test)s
%(vlm)s

This PR updates the dev dependencies in the pyproject.toml file, so vllm extra dependencies are not included in the dev extra.

Fix #4228.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
Copy link
Member Author

albertvillanova commented Oct 8, 2025

The error in the associated issue is now fixed. See e.g.: https://github.com/huggingface/trl/actions/runs/18339469824/job/52231273302?pr=4229

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@albertvillanova albertvillanova merged commit e2c97a8 into huggingface:main Oct 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails: torch.AcceleratorError: CUDA error: an illegal memory access was encountered

3 participants