-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Remove obsolete research_projects directory #4243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The research_projects directory contains outdated examples that no longer work with the current TRL API.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
- Deleted docs/source/detoxifying_a_lm.md as requested by qgallouedec - Removed reference from docs/source/_toctree.yml This resolves qgallouedec's review comment on PR #4243.
# Conflicts: # docs/source/detoxifying_a_lm.md # docs/source/example_overview.md # docs/source/peft_integration.md # examples/research_projects/stack_llama_2/scripts/README.md
Remove trailing space from line 22 that was introduced during merge with PR #4235 (markdown style enhancements). This addresses qgallouedec's review comment requesting to revert unrelated style changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @sergiopaniego, @burtenshaw, we are removing these two-and-a-half-year-old examples. I'll leave it up to you to decide whether it would be wise to provide an updated version somewhere, at some point.
Analysis:
examples/research_projects/
📁 Directory Structure
🔍 Usage Analysis
Documentation References:
docs/source/example_overview.md:77
- Links to research_projectsdocs/source/detoxifying_a_lm.md:11-12
- Links to toxicity scriptsdocs/source/peft_integration.md:10-12
- Links to stack_llama scriptsCI/CD Integration:
.github/workflows/
Makefile
Obsolescence Evidence
1. Broken API Usage:
Current
PPOConfig
: No longer acceptssteps
ormodel_name
parameters (confirmed via inspection - 163 total params, neither exists)2. Deprecated Imports:
3. Ancient Code Patterns (Last meaningful update: July 2023):
📊 Maintenance Status
Assessment
Reasons for removal:
examples/scripts/
Changes
examples/research_projects/
directory (21 files, 2116 deletions)docs/source/example_overview.md
to remove referencedocs/source/detoxifying_a_lm.md
to remove broken script linksdocs/source/peft_integration.md
to remove broken script links