Skip to content

Conversation

albertvillanova
Copy link
Member

Install peft from main for CI tests with dev dependencies.

This PR updates the CI tests with dev dependencies and aligns peft with the rest of the Hugging Face libraries, installing its dev version from the GH repo main branch.

Additionally, this PR fixes the CI AttributeError: type object 'DynamicCache' has no attribute 'from_legacy_cache': the fix is already on peft main branch:

Fix #4248.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, lgtm. peft is an optional dependency, but since it is widely used, I think it makes sense to test it here with dev.

@albertvillanova
Copy link
Member Author

Yes, and also note that before this PR it was already installed, but not from main branch repo, but latest stable version:

trl/pyproject.toml

Lines 103 to 104 in f853e09

# peft
"peft>=0.8.0",

@albertvillanova albertvillanova merged commit f582792 into huggingface:main Oct 10, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails with dev dependencies: AttributeError: type object 'DynamicCache' has no attribute 'from_legacy_cache'

3 participants