Skip to content

Conversation

albertvillanova
Copy link
Member

Fix CI slow test: https://github.com/huggingface/trl/actions/runs/18399649932/job/52425772805

ValueError: Unknown loss type: dapo

FAILED tests/slow/test_grpo_slow.py::TestGRPOTrainerSlow::test_training_with_liger_grpo_loss_and_peft_0_trl_internal_testing_tiny_LlamaForCausalLM_3_2 - ValueError: Unknown loss type: dapo
FAILED tests/slow/test_grpo_slow.py::TestGRPOTrainerSlow::test_training_with_liger_grpo_loss_and_peft_1_trl_internal_testing_tiny_MistralForCausalLM_0_2 - ValueError: Unknown loss type: dapo

Follow-up to:

@albertvillanova
Copy link
Member Author

albertvillanova commented Oct 10, 2025

Test passed: https://github.com/huggingface/trl/actions/runs/18407670353/job/52451408042?pr=4254

pytest -m "slow" tests/slow/test_grpo_slow.py::TestGRPOTrainerSlow::test_training_with_liger_grpo_loss_and_peft_0_trl_internal_testing_tiny_LlamaForCausalLM_3_2 --report-log "slow_tests.log"
============================= test session starts ==============================
platform linux -- Python 3.11.13, pytest-8.4.2, pluggy-1.6.0
rootdir: /__w/trl/trl
configfile: pyproject.toml
plugins: anyio-4.11.0, cov-7.0.0, rerunfailures-15.1, xdist-3.8.0, reportlog-0.4.0
collected 1 item

tests/slow/test_grpo_slow.py .                                           [100%]

@albertvillanova albertvillanova marked this pull request as ready for review October 10, 2025 14:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova albertvillanova merged commit 98488e0 into huggingface:main Oct 10, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants