Read docker logs from stderr as well as stdout #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around an issue with besu logs being switched to stderr, however seems reasonable to be flexible in this verification. We can enforce stdout for Besu if necessary earlier in the checks. Signed-off-by: Simon Dudley <[email protected]>
macfarla
approved these changes
Nov 2, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
think this still makes sense, now that we have also added unit test to ensure the regular logging goes to stdout
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 17, 2025
Works around an issue with besu logs being switched to stderr, however seems reasonable to be flexible in this verification. We can enforce stdout for Besu if necessary earlier in the checks. Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around an issue with besu logs being switched to stderr, however seems reasonable to be flexible in this verification. We can enforce stdout for Besu if necessary earlier in the checks.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests