fix : eth_estimateGas fails with EIP-7702 (authorizationList) transactions #9345
Conversation
Signed-off-by: Ifeoluwa Sanni <[email protected]>
Signed-off-by: Ifeoluwa Sanni <[email protected]>
Signed-off-by: Ifeoluwa Sanni <[email protected]>
daniellehrner
left a comment
daniellehrner
left a comment
There was a problem hiding this comment.
I do not see any changes to EthEstimateGas, don't we need those? In general we need to add tests to EthEstimateGasAcceptanceTest, unit tests alone with mocking the results, won't tell us if the change actually works
There was a problem hiding this comment.
This class is empty and can be deleted
There was a problem hiding this comment.
This class is empty and can be deleted
There was a problem hiding this comment.
What does this class do? It sems to only throw exceptions
| Bytes.fromHexStringLenient(r).toUnsignedBigInteger(), | ||
| Bytes.fromHexStringLenient(s).toUnsignedBigInteger(), | ||
| Bytes.fromHexStringLenient(v).get(0))); | ||
| Bytes.fromHexStringLenient(recoveryId).get(0))); // ← Use recoveryId instead of v |
There was a problem hiding this comment.
I think the comment can be deleted, it is already explained above
There was a problem hiding this comment.
Why do we need to change an existing test?
There was a problem hiding this comment.
I think you can just reuse the class from ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/CodeDelegation.java
Signed-off-by: Ifeoluwa Sanni <[email protected]>
This reverts commit 567fc78. Signed-off-by: Ifeoluwa Sanni <[email protected]>
This reverts commit 77de45c. Signed-off-by: Ifeoluwa Sanni <[email protected]>
Signed-off-by: Ifeoluwa Sanni <[email protected]>
into fix-hyperledger#9230 fix sign off Signed-off-by: Ifeoluwa Sanni [email protected]
2 participants
PR description
fixes the failure EIP-7702 (authorizationList) transactions with eth_estimateGas
Fixed Issue(s)
fixes #9230
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests