Skip to content

use error code 3 for reverts #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 11, 2025
+5 −3
Merged

use error code 3 for reverts #9365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b611739
use error code 3 for reverts
macfarla Oct 15, 2025
c426a49
Merge branch 'main' of github.com:hyperledger/besu into revert-error-…
macfarla Oct 17, 2025
7eb87cf
Merge branch 'main' of github.com:hyperledger/besu into revert-error-…
macfarla Oct 23, 2025
2964bf1
update tests for revert error code 3
macfarla Oct 27, 2025
b6cee28
changelog
macfarla Oct 27, 2025
31c3878
merge
macfarla Nov 4, 2025
914854e
Merge branch 'main' into revert-error-code
macfarla Nov 10, 2025
9bc8267
Merge branch 'main' into revert-error-code
macfarla Nov 11, 2025
44cb8d9
Merge branch 'main' into revert-error-code
macfarla Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Remove `--Xsnapsync-server-enabled` deprecated since 25.7.0. Use `--snapsync-server-enabled` instead.
- Remove `--Xsnapsync-synchronizer-pre-merge-headers-only-enabled` deprecated since 25.7.0. Use `--snapsync-synchronizer-pre-checkpoint-headers-only-enabled` instead.
- Remove `--Xhistory-expiry-prune` deprecated since 25.7.0. Use `--history-expiry-prune` instead.
- Use error code 3 for execution reverted [#9365](https://github.com/hyperledger/besu/pull/9365)
Copy link
Contributor

@siladu siladu Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like quite a big breaking change to just release without warning, especially since it'll end up in the fusaka release. Does this warrant 3 months notice?

Copy link
Contributor

@garyschulte garyschulte Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ambivalent here. If geth and erigon, both of which are used for block explorers and rpc instances, have used this since 2022... how much would it really break?

Maybe private chains or alt-L1s?

Copy link
Contributor

@siladu siladu Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If geth and erigon, both of which are used for block explorers and rpc instances, have used this since 2022

That lessens the concern somewhat.

how much would it really break?

Are you suggesting that noone is using eth_call/eth_estimateGas with besu on mainnet? I don't know the answer to that, I just thought it likely someone is.

Maybe private chains

For sure.

Copy link
Contributor Author

@macfarla macfarla Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this was kind of my thinking. leaving it until after the fusaka release is nbd. but yeah this is bringing besu in line with other ELs so it's probably only really a breaking change if you're only using besu - so private chains.

maybe there is a bigger discussion to have around how we communicate changes to our RPCs

Copy link
Contributor

@siladu siladu Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe historically the default for breaking RPC is 3 months notice. Previously think it was tied to quarterly releases, now think we agreed "upcoming breaking changes" is sufficient.
I'm not sure whether breaking RPCs for private networks should be treated differently to public networks.

I don't feel too strongly if you are convinced the impact is low, just wanted to flag it.

Copy link
Contributor Author

@macfarla macfarla Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this change brings besu in line with other ELs, think it's ok to flag in the changelog in the same release. No advance warning needed.

- eth_createAccessList now returns success result if execution reverted [#9358](https://github.com/hyperledger/besu/pull/9358)

### Upcoming Breaking Changes
Expand All @@ -18,6 +19,7 @@
### Additions and Improvements
- Update to vertx 4.5.22 [#9375](https://github.com/hyperledger/besu/pull/9375)
- Add `opcodes` optional parameter to RPC methods: `debug_standardTraceBlockToFile`, `debug_standardTraceBadBlockToFile`, `debug_traceBlockByNumber`, `debug_traceBlockByHash`, `debug_traceTransaction`, `debug_traceBlock`, `debug_traceCall` for tracing specified opcodes [#9335](https://github.com/hyperledger/besu/pull/9335)
- Use error code 3 for execution reverted [#9365](https://github.com/hyperledger/besu/pull/9365)
- eth_createAccessList now returns success result if execution reverted [#9358](https://github.com/hyperledger/besu/pull/9358)
- Use Eclipse Temurin OpenJDK JRE in Besu docker image [#9392](https://github.com/hyperledger/besu/pull/9392)

Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/response/RpcErrorType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public enum RpcErrorType implements RpcMethodError {
REPLAY_PROTECTED_SIGNATURE_REQUIRED(-32000, "ChainId is required"),
TX_FEECAP_EXCEEDED(-32000, "Transaction fee cap exceeded"),
REVERT_ERROR(
-32000,
3,
"Execution reverted",
data -> JsonRpcErrorResponse.decodeRevertReason(Bytes.fromHexString(data))),
TRANSACTION_NOT_FOUND(-32000, "Transaction not found"),
Expand Down
2 changes: 1 addition & 1 deletion .../test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth_latest/eth_call_revert.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"jsonrpc": "2.0",
"id": 3,
"error": {
"code": -32000,
"code": 3,
"message": "Execution reverted",
"data": "0x7d88c1856cc95352"
}
Expand Down
2 changes: 1 addition & 1 deletion ...esources/org/hyperledger/besu/ethereum/api/jsonrpc/eth_latest/eth_estimateGas_revert.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"jsonrpc": "2.0",
"id": 3,
"error": {
"code": -32000,
"code": 3,
"message": "Execution reverted",
"data": "0x00"
}
Expand Down