Add configuration options for BAL-related parameters #9387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirgee
force-pushed
the
bal-config
branch
5 times, most recently
from
e69898b to
bbf87c6
Compare
mirgee
force-pushed
the
bal-config
branch
2 times, most recently
from
2f9b9d0 to
9cb2557
Compare
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
mirgee
commented
Nov 6, 2025
...java/org/hyperledger/besu/ethereum/mainnet/staterootcommitter/StateRootCommitterImplBal.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
matkt
reviewed
Nov 7, 2025
...c/test/java/org/hyperledger/besu/consensus/merge/blockcreation/MergeGenesisConfigHelper.java
Outdated
Show resolved
Hide resolved
matkt
reviewed
Nov 7, 2025
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
...a/org/hyperledger/besu/ethereum/mainnet/staterootcommitter/StateRootCommitterFactoryBal.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Miroslav Kovar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following BAL-related CLI options:
--Xbal-optimization-enabled(default: true) - allows enabling or disabling BAL-based state root pre-computation (and possibly other optimizations in the future)--Xbal-trust-state-root(default: false) - defines whether the state root computed from BALs should be trusted; if not, it will be re-computed synchronously and the results compared--Xbal-lenient-on-mismatch(default: true) - defines whether to only log an error message or invalidate the block on mismatch between state root computed based on BAL and synchronously--Xbal-state-root-timeout(default: 1000) - the duration for which to wait for the BAL-based state root computation future to complete in millisecondsRenames
--Xapi-block-access-list-enabledto--Xbal-api-enabled.Merging this PR will easily allow adding the CLI option to enable logging constructed and block's BALs on mismatch as mentioned in #9402 .
Followup PRs will add
--Xbal-trust-state-rootand--Xbal-log-bals-on-mismatch(or similar).Currently
--Xbal-optimization-enableddoesn't really enable any performance optimizations, however it's probably better to minimize changes to CLI flags than choosing a temporary name which is fitting better at the moment.