Skip to content

Conversation

@shoaebjindani
Copy link

Upgraded LDAP dependency to v3.4.12
Includes performance and stability improvements
Keeps project aligned with latest upstream fixes

@shoaebjindani shoaebjindani requested a review from a team as a code owner November 5, 2025 12:18
@shoaebjindani shoaebjindani marked this pull request as draft November 5, 2025 12:20
Shoaeb Jindani added 4 commits November 6, 2025 17:31
Signed-off-by: Shoaeb Jindani <[email protected]>
Signed-off-by: Shoaeb Jindani <[email protected]>
Signed-off-by: Shoaeb Jindani <[email protected]>
Signed-off-by: Shoaeb Jindani <[email protected]>
@shoaebjindani shoaebjindani marked this pull request as ready for review November 6, 2025 12:21
@shoaebjindani
Copy link
Author

@bestbeforetoday can you please review and merge ?

@bestbeforetoday
Copy link
Member

bestbeforetoday commented Nov 6, 2025

@shoaebjindani can you explain the intent of this pull request? It appears to only add some additional indirect dependencies that are not actually used by the fabric-ca code. For example, running go mod why github.com/go-ldap/ldap/v3 reports:

main module does not need package github.com/go-ldap/ldap/v3

Running go mod tidy removes all the additions you have made since they are not used.

Is your intent to replace gopkg.in/ldap.v2 with github.com/go-ldap/ldap/v3? If so, you need to modify the code that references it in lib/server/ldap/client.go and update the module dependencies accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants