Make sure the permissions controller is displayed if the camera permi…#142
Open
onato wants to merge 2 commits intohyperoslo:masterfrom
Open
Make sure the permissions controller is displayed if the camera permi…#142onato wants to merge 2 commits intohyperoslo:masterfrom
onato wants to merge 2 commits intohyperoslo:masterfrom
Conversation
b80b0dc to
8787b2a
Compare
…ssions are not determined. hyperoslo#141
|
We are having this issue crop up as well, would love the fix to be included |
|
The permissions controller fix is not working for me. You have your code below this line let useCamera = Permission.Camera.needsPermission && Permission.Camera.status == .authorized Which seems to make your code never return nil if useCamera, Permission.Camera.status == .notDetermined { |
Collaborator
|
Added the showStatusBar separately. What I hear from @neodave is that this proposed fix doesn't work. Any clues what might work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ssions are not determined. #141
Possible something similar should be done with Photos permissions. Should we really show the permissions controller if the user has said no to photos and yes to the camera?