Fixes for App Store submission warning - "ITMS-90683: Missing Purpose String in Info.plist"#188
Open
lawmaestro wants to merge 1 commit intohyperoslo:masterfrom
Open
Conversation
…String in Info.plist" * Added compiler flag `GALLERY_USE_LOCATION` which is used to partition usage of `CoreLocation`. If the flag isn't set then the option within `Camera` to record the location is not available. * This change forces consumers of the framework to define `GALLERY_USE_LOCATION` should they wish to compliment photos with location information. * By introducing this compiler flag we're able to conditionally remove dependencies on `CoreLocation` when we're not interested in using location information. This in turn avoids the needles requirement to set a `NSLocationWhenInUseUsageDescription` key in the Apps plist file regardless. * By having a better way to address this warning this will avoid future App Store rejections when Apple make the inclusion of a `NSLocationWhenInUseUsageDescription` string mandatory when using `CoreLocation`. * Up-versioned to `2.5.0` as this will be a breaking change for consumers using the `recordLocation` property on `Camera`. * Updated `README.md`
Author
|
This PR addresses the issue highlighted here |
Author
|
Is there any update on the above? 👆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GALLERY_USE_LOCATIONwhich is used to partition usage ofCoreLocation. If the flag isn't set then the option withinCamerato record the location is not available.GALLERY_USE_LOCATIONshould they wish to compliment photos with location information.CoreLocationwhen we're not interested in using location information. This in turn avoids the needles requirement to set aNSLocationWhenInUseUsageDescriptionkey in the Apps plist file regardless.NSLocationWhenInUseUsageDescriptionstring mandatory when usingCoreLocation.2.5.0as this will be a breaking change for consumers using therecordLocationproperty onCamera.README.md