Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 88.86% 88.33% -0.54%
==========================================
Files 79 100 +21
Lines 7652 7764 +112
Branches 910 932 +22
==========================================
+ Hits 6800 6858 +58
- Misses 578 632 +54
Partials 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eefad50 to
917e2f4
Compare
|
@jlaehne, @CSSFrancis, would you be able to review this PR? |
|
Checking the integration test suite, I added back the signals submodules (for example, The remaining failure (hyperspy_gui_ipywidgets) is fixed in hyperspy/hyperspy_gui_ipywidgets#96. |
I merged the corresponding PR. LGTM if the tests pass, @CSSFrancis do you want to have another quick look? |
9c285bf to
5c66672
Compare
|
@CSSFrancis, in case, you want to have a look, this is a large PR, but I think that it worth checking is the API reference: https://exspy--160.org.readthedocs.build/en/160/reference/index.html and privatized imports. The integration test suite passed except that hyperspy_gui_ipywidgets needs a release to include hyperspy/hyperspy_gui_ipywidgets#96. The rest is moving import around to defer import, etc. and implementing lazy loading using |
…ct to `exspy._misc`, etc and speed up import
- don't use import of `from exspy import signals` at the top level - move material property and material functionalities to separate module
This PR will need hyperspy/hyperspy#3569 to be release and I opened it to try if hyperspy/hyperspy#3569 works well.
All signals import are now ~0.3s.
Progress of the PR
lazy-loader,exspy.utilsto avoid import redirection,upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:exspybuild of this PR (link in github checks)