Open
Conversation
Anonimous-User
requested changes
Nov 20, 2025
| size_t detailed_temps_group_id; | ||
| size_t detailed_temps_cell_id; | ||
| size_t detailed_temps_board_id; | ||
| size_t current_voltage_group_chip_id; |
Contributor
There was a problem hiding this comment.
nitpick but could you not say "current_xxx"? it makes it seem like it's related to current and rather than this variable's immediate value
Contributor
Anonimous-User
left a comment
Anonimous-User
left a comment
There was a problem hiding this comment.
resolve merge conflicts too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.