Feat/current steering system first version is done#46
Open
Feat/current steering system first version is done#46
Conversation
Author
|
i just saw the million narrowing conversions so we'll fix those wednesday |
Author
|
Fixed the linter errors, some are no linted bc in the current shared firmware the analog datatype is a float for some reason rather than uint |
Author
|
Calibration is partially unfinished in VCF tasks (since idk how the input will be exactly) other than that i think i got the rest so far |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We finished the .h and .cpp for the steering system, but we don't currently have all the logic for deciding which is the better sensor to output in all scenarios (since we haven't tested the sensors with it).
Other main thing is we don't entirely understand how calibration is going to work with the button press and scheduler and all so might need to edit that too.