Add feature: Local map overlays for mission planner#2164
Add feature: Local map overlays for mission planner#2164paul-fornage wants to merge 37 commits intoiNavFlight:masterfrom
Conversation
fixed issue where panning would not work when mouse-down was over a feature imported by the user in mission planner
…at werent custom user features
Not working, but I want to keep working on a different machine
Not working, but I want to keep working on a different machine
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
I accidentally pushed some changes my IDE made to this file, and then undid them manually, but for some reason this is still in the diff. Feel free to not merge this file
There was a problem hiding this comment.
no big deal. probably extra empty line at the end of file
|
@Scavanger maybe worth to keep in mind when porting GF to 8.0. |
|
Please resolved the conflicts. Also, it's Mission Control, not Mission Planner ;) |
|
Thanks for this. |
|
No tbh :) I can figure it out and make it not 37 commits lol but I have long since forgotten about this and would have to relearn the project context for the merge conflicts. I'm not opposed but I'm busy for the holidays and the change wouldn't be able to come now. I think I've also improved since then too so I would probably end up cleaning it up in other ways. And also I changed package lock? silly behavior. |
|
Nice work @paul-fornage! I suggest closing this and going with #2519, which I created based on this, but based on a fresh master and a pair of extra eyes. Basically same functionality straight off, with some usability improvements IMO. |
Sounds good. Thank you for this, I'm glad it got cleaned up |
|
Superseded by #2519 which reimplements this feature with usability improvements. |
6 participants
This PR makes it possible for the user to drag and drop a GEO file containing property lines, trails, waypoints, flight restricted areas, or anything else on to the map. The change does not affect anything about the actual mission and is purely for visual reference.
While the feature is similar to GEO-fencing, an upcoming rumored addition to iNav, this allows the user to easily import existing data in almost any applicable format (GEOJSON, KML, GPX, TOPOJSON, and IGC) to be able to more easily identify or plan around various landmarks in mission planner.
To put it bluntly, I am not a JS dev, and some conventions may be missing. Especially those specific to this project. But I did my best to emulate the style in the rest of the project, if not with more comments. If there are any issues I am in the iNav discord under the name BeanTime, and I'm always open to suggestions or changes that need to be made.