Fix transpiler conflict detection and AST consistency#2513
Merged
sensei-hacker merged 1 commit intoiNavFlight:maintenance-9.xfrom Jan 6, 2026
Merged
Conversation
This addresses two issues identified by Qodo bot code review: Issue #3: Conflict detection indexing bug - Previously only ifthen handlers got unique keys - All on.always() blocks collapsed to single key, causing: * False positives: assignments in different blocks flagged as conflicts * Disabled race detection: check requires multiple handlers but all collapsed to 1 - Fix: Give every handler a unique index regardless of type - Location: js/transpiler/transpiler/analyzer.js:528-530 Issue #5: Raw values not wrapped in Literal nodes - >= and <= optimization passed raw numbers instead of AST nodes - Fix: Wrap constValue±1 in {type: 'Literal', value: ...} objects - Maintains AST consistency throughout pipeline - Location: js/transpiler/transpiler/condition_generator.js:300,307 All 27 transpiler test suites pass with 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues identified by Qodo bot code review on PR #2482:
Changes
Issue #3: Conflict Detection Indexing Bug
Problem:
ifthenhandlers received unique keyson.always()blocks collapsed to single key"on.always"on.always()blocks incorrectly flagged as conflictshandlers.length > 1, but all blocks collapsed to 1 keyFix:
${stmt.handler}:${stmtIndex}js/transpiler/transpiler/analyzer.js:528-530Impact:
on.always()handlersIssue #5: Raw Values Not Wrapped in Literal Nodes
Problem:
>=and<=optimization passed raw numbers instead of AST nodescondition.rightshould always be an AST nodeFix:
constValue±1in{type: 'Literal', value: ...}objectsjs/transpiler/transpiler/condition_generator.js:300,307Impact:
Testing
✅ All 27 transpiler test suites pass with 0 failures
Related