feat(rewrites): improve how constant sort values are dropped #11617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we only dropped constant sort values if - it was an EXACT Literal. if it was derived, eg `ibis.literal(5) + 1`, then we wouldn't. - if the merge_select_select decided to return the original select instead of merging them (eg because of a window function, unnest, etc), then we wouldn't see this optimization.
github-actions
bot
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we only dropped constant sort values if
ibis.literal(5) + 1, then we wouldn't.This is a followup to a TODO that I found at 7a6f0a1#diff-2719b402427dca65945905bfc259790600013287258e555367581729c40d837eR323-R328