Introduce draw_mesh_cache in mesh::Renderer
#3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failing CI is from an upstream rustdoc change: rust-lang/rust#138907 |
|
This is great. We have ~25% performance increase by reusing the meshes! Hoping this gets merged soon! 👍 |
hecrj
force-pushed
the
cheap_mesh_clone
branch
from
8cb7c16 to
afb3b8f
Compare
hecrj
changed the title
Meshes cheaply cloneable by using Arc<[T]> in iced_graphics::mesh::Indexeddraw_mesh_cache in mesh::Renderer
hecrj
approved these changes
Nov 29, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I have moved the Cache in wgpu to mesh which lets renderers reuse buffers under the hood.
This also avoids redundant Arc when caching isn't desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have large meshes that I'd like to not have to recreate/clone every time I draw them. When using
wgpuI can use aiced_wgpu::geometry::Cache, however a renderer-agnostic way to cache these would be nice, even if the tiny-skia renderer doesn't support meshes.