Refactor MFEM objects away from MFEMGeneralUserObject by lindsayad · Pull Request #32701 · idaholab/moose

lindsayad · 2026-04-02T22:36:40Z

Closes #31434

moosebuild · 2026-04-03T02:07:47Z

Job Documentation, step Docs: sync website on 1c3e5c0 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2026-04-06T20:44:14Z

Job Precheck, step Clang format on ff03cf6 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/32701/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 23ccd6e15d138300b1cdb35925777634fd5c715f

moosebuild · 2026-04-07T07:03:04Z

Job Coverage, step Generate coverage on 1c3e5c0 wanted to post the following:

Framework coverage

	217dea	#32701 1c3e5c
	Total	Total	+/-	New
Rate	85.87%	85.87%	+0.00%	100.00%
Hits	132046	132210	+164	400
Misses	21723	21748	+25	0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

alexanderianblair

I like this a lot - major improvement to the user experience. Just one minor query:

nmnobre

I've just skimmed (technically on holiday... I'm a disaster at holidaying): I'd like some docs. :P I can see we removed the docs for MFEMGeneralUserObject, but its replacements didn't get the same honours. Also, let's run Valgrind if we haven't.

nmnobre

In addition to thanking you for the obvious improvement this is, I'd also like to honestly thank you for all the docstrings you added :)

nmnobre · 2026-04-15T15:48:37Z

At the risk of delaying this a few more hours, how do you like this: nmnobre@473f244 ?

Update MFEM base header documentation and small API cleanup. - add doxygen coverage for the non-override MFEMObject and MFEMExecutedObject APIs - document the MFEM executed-object dependency metadata structures - remove unnecessary interface using-declarations from MFEMObject These changes are limited to framework/include/mfem/base/MFEMObject.h and framework/include/mfem/base/MFEMExecutedObject.h. Co-authored-by: OpenAI Codex <codex@openai.com>

Tighten the MFEM executed-object cache and naming cleanup around the ongoing warehouse-backed refactor. This updates MFEMExecutedObject to lazily build requested/supplied dependency sets, switches it over to getParam-based access, and adds missing doxygen on MFEMProblem and FEProblemBase helper APIs touched by this work. On the MFEM problem side, remove immediate warehouse round-trips after addObject() where the returned shared_ptr is already sufficient, and simplify a few remaining shared_ptr casts. Also replace misleading UserObjectName parameters used for MFEM-specific systems with dedicated derivative string classes: - MFEMFESpaceName for MFEM FESpace references - MFEMSolverName for MFEM solver/preconditioner references The new MFEM name types are registered with the parser/JSON machinery, and the affected MFEM variables, solvers, indicators, problem helpers, and unit tests are updated accordingly. Co-authored-by: OpenAI Codex <codex@openai.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…d::string> No existing execute object produces more than one resource, and there is no precedent in the libMesh-backed MOOSE objects for that either. Replace the three plural produced*Names() virtual methods returning std::set<std::string> with singular produced*Name() methods returning std::optional<std::string>, and update all six overriding subclasses and the documentation accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rface "supplied" is the term used by DependencyResolverInterface (getSuppliedItems). Rename the three virtual helpers accordingly across all overriding subclasses and documentation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>

nmnobre

Thanks again for this @lindsayad, it's a clear usability improvement (and thanks for tweaking the name to haveParameter instead and squashing the commits! 😍).
I approve those changes which aren't mine.

The only thing still itching is {get,has}MFEMObject(), though not enough to hold this I don't think. Only one is templated but they both could be, and the template argument encloses sufficient information to determine the system unambiguously, right? Problem is I can't think of a way to do this, but to implement a map...

lindsayad · 2026-04-16T22:52:02Z

Thanks for the review!

The only thing still itching is {get,has}MFEMObject(), though not enough to hold this I don't think. Only one is templated but they both could be, and the template argument encloses sufficient information to determine the system unambiguously, right? Problem is I can't think of a way to do this, but to implement a map...

Could be potential follow-on work

moosebuild · 2026-04-16T23:03:55Z

Job Test, step Results summary on 1c3e5c0 wanted to post the following:

Framework test summary

Compared against 217deaa in job civet.inl.gov/job/3749200.

No change

Modules test summary

Compared against 217deaa in job civet.inl.gov/job/3749200.

No change

nmnobre · 2026-04-17T11:16:14Z

Failure in fetching RELAP-7 is surely unrelated.

lindsayad force-pushed the mfem-object-refactor-31434 branch from a45642d to 2f4bd12 Compare April 2, 2026 22:55

lindsayad force-pushed the mfem-object-refactor-31434 branch 2 times, most recently from 2d2f48d to f641dc0 Compare April 7, 2026 04:28

GiudGiud assigned lindsayad and unassigned lindsayad Apr 7, 2026

lindsayad force-pushed the mfem-object-refactor-31434 branch 4 times, most recently from 032a699 to 025f6b5 Compare April 8, 2026 22:24

lindsayad marked this pull request as ready for review April 9, 2026 15:18

lindsayad requested review from alexanderianblair, nmnobre and roystgnr as code owners April 9, 2026 15:18

lindsayad added the PR: Ready for review/merge label Apr 9, 2026

alexanderianblair approved these changes Apr 10, 2026

View reviewed changes

Comment thread test/tests/mfem/kernels/tests Outdated

nmnobre requested changes Apr 10, 2026

View reviewed changes

moosebuild added the PR: Failed but allowed label Apr 11, 2026

lindsayad force-pushed the mfem-object-refactor-31434 branch from 654f80e to ce8ef57 Compare April 13, 2026 18:56

moosebuild removed the PR: Failed but allowed label Apr 13, 2026

lindsayad requested a review from nmnobre April 13, 2026 18:57

nmnobre requested changes Apr 14, 2026

View reviewed changes

lindsayad force-pushed the mfem-object-refactor-31434 branch 2 times, most recently from 5735046 to 4ca7f48 Compare April 14, 2026 18:22

lindsayad mentioned this pull request Apr 14, 2026

Update UserObjectInterface to work with Kokkos UOs #32755

Merged

moosebuild added the PR: Failed but allowed label Apr 15, 2026

lindsayad requested a review from nmnobre April 15, 2026 14:59

lindsayad and others added 16 commits April 15, 2026 16:57

Reverse addition order in MFEMExecutedObjectDependencyTest

c29c9f8

Use DependencyResolverInterface

c5a147f

Request more slots for ldg-h mms test

4700cf5

Fix unity build post-refactors

bdcf270

Add duplicate supplier unit test error check

41bab30

Request more slots for fv gap conductance mms test

81c06e5

Add docs for MFEMObject and MFEMExecutedObject

bc01925

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Try removing linux platform requirement

5648998

Properly register L2Error variable dependency as required

7ed714b

Rm some redundancy

bebf1b8

Try to remove uses of shortName in interface classes

355aecd

Just use name() in MFEMVectorPostprocessor for consistency

54a8f8d

lindsayad force-pushed the mfem-object-refactor-31434 branch from 4ca7f48 to 54a8f8d Compare April 15, 2026 23:57

moosebuild added PR: Failed but allowed and removed PR: Failed but allowed labels Apr 15, 2026

Further simplify MFEMExecutedObject

76e6f8c

nmnobre mentioned this pull request Apr 16, 2026

Further simplify MFEMExecutedObject thanks to improved queryParam() lindsayad/moose#14

Merged

moosebuild removed the PR: Failed but allowed label Apr 16, 2026

Add MooseBase::haveParameter(), use it to improve queryParam()

1c3e5c0

Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>

lindsayad force-pushed the mfem-object-refactor-31434 branch from b5ab1ff to 1c3e5c0 Compare April 16, 2026 21:55

nmnobre approved these changes Apr 16, 2026

View reviewed changes

nmnobre merged commit 52c5d71 into idaholab:next Apr 17, 2026
68 of 69 checks passed

nmnobre mentioned this pull request Apr 17, 2026

Refactor {get,has}MFEMObject() to avoid dealing w/ system names #32781

Open

Conversation

lindsayad commented Apr 2, 2026

Uh oh!

moosebuild commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Apr 6, 2026

Uh oh!

moosebuild commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Framework coverage

Modules coverage

Full coverage reports

Uh oh!

alexanderianblair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nmnobre left a comment

Choose a reason for hiding this comment

Uh oh!

nmnobre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nmnobre commented Apr 15, 2026

Uh oh!

nmnobre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lindsayad commented Apr 16, 2026

Uh oh!

moosebuild commented Apr 16, 2026

Framework test summary

Modules test summary

Uh oh!

nmnobre commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moosebuild commented Apr 3, 2026 •

edited

Loading

moosebuild commented Apr 7, 2026 •

edited

Loading

nmnobre left a comment •

edited

Loading