Skip to content

feat: Remove rfc number #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holloway merged 2 commits into from
Mar 3, 2026
Merged

feat: Remove rfc number #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33f553
feat: remove rfc number
holloway Mar 3, 2026
f9d0221
feat: remove rfc number from website
holloway Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion precomputer/src/utils/queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const getQueueCommon = async ({ api, params }: Props): Promise<QueueCommo
return {
name,
title,
rfcNumber: rfcNumber ?? undefined,
pages,
clusters: typeof clusterNumber === 'number' ? [clusterNumber] : undefined,
enqueuedAtIso: enqueuedAt?.toISOString(),
Expand Down
9 changes: 1 addition & 8 deletions website/app/components/FinalReviewIndexTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,6 @@ const columns = [
},
sortingFn: 'alphanumeric',
}),
columnHelper.accessor('rfcNumber', {
header: 'RFC Number',
cell: data => data.getValue(),
sortingFn: 'alphanumeric',
sortUndefined: 'last',
}),
columnHelper.accessor(
'labels', {
header: 'Labels',
Expand Down Expand Up @@ -118,8 +112,7 @@ const table = useVueTable({
if (searchQuery.value && searchQuery.value.trim()) {
const searchTerm = searchQuery.value.trim().toLowerCase()
const nameMatch = d.name?.toLowerCase().includes(searchTerm)
const rfcMatch = d.rfcNumber?.toString().toLowerCase().includes(searchTerm)
if (!nameMatch && !rfcMatch) {
if (!nameMatch) {
return false
}
}
Expand Down
13 changes: 1 addition & 12 deletions website/app/components/QueueIndexTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,6 @@ const columns = [
},
sortingFn: 'alphanumeric',
}),
columnHelper.accessor('rfcNumber', {
header: 'RFC Number',
cell: data => data.getValue(),
sortingFn: (rowA, rowB, columnId) => {
const a = Number(rowA.getValue(columnId))
const b = Number(rowB.getValue(columnId))
return a - b
},
sortUndefined: 'last',
}),
columnHelper.accessor(
'labels', {
header: 'Labels',
Expand Down Expand Up @@ -198,8 +188,7 @@ const table = useVueTable({
if (searchQuery.value && searchQuery.value.trim()) {
const searchTerm = searchQuery.value.trim().toLowerCase()
const nameMatch = d.name?.toLowerCase().includes(searchTerm)
const rfcMatch = d.rfcNumber?.toString().toLowerCase().includes(searchTerm)
if (!nameMatch && !rfcMatch) {
if (!nameMatch) {
return false
}
}
Expand Down
2 changes: 1 addition & 1 deletion website/app/utils/validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const QueueCommonItemSchema = z.object({
deadlineIso: z.string().optional(), // ISO date
labels: LabelCommonSchema.array().optional(),
clusters: z.number().array().optional(),
rfcNumber: z.number().optional(),
// rfcNumber: z.number().optional(),
pages: z.number().optional(),
enqueuedAtIso: z.string().optional(), // ISO date
ianaStatus: IanaStatusCommonSchema.optional(),
Expand Down