Merged
Conversation
Contributor
Author
I don't know what I need to do in this regard. |
Member
Don't worry about it for now. If you add another commit to the PR, follow what's at https://www.conventionalcommits.org/en/v1.0.0/. ( If you don't add another commit, we can deal with it at squash time. |
kesara
requested changes
Aug 8, 2025
Member
kesara
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Can you update the README.md usage section on how to use the this a CLI tool?
8e42637 to
28aba39
Compare
This adds a script entrypoint to run the markup() function on a bunch of files. This makes it possible to use rfc2html with pipx/uvx as follow: $ wget https://www.rfc-editor.org/rfc/rfc8446.txt $ pipx rfc2html -v rfc8446.txt rfc8446.txt.html
kesara
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a script entrypoint to run the markup() function on a bunch of files. This makes it possible to use rfc2html with pipx/uvx as follow:
I've tested it manually on both py3.7 (the oldest python that compiles on my machine) and py3.10 (my system python). I believe the code works with py2 as well but I can't test it. Tell me if you think it deserves a unittest.