XEP-0115 Entity Capabilities: compliance fixes for §5.4 and §6.2#3191
Open
XEP-0115 Entity Capabilities: compliance fixes for §5.4 and §6.2#3191
Conversation
Co-authored-by: akrherz <210858+akrherz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate Openfire's XEP-0115 entity capabilities support
XEP-0115 Entity Capabilities: compliance fixes for §5.4 and §6.2
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openfire's XEP-0115 implementation claimed Version 1.4 compliance but had several gaps against the §5.4 processing method and §6.2 discovery rules.
Fixes
Missing
nodeattribute in disco#info requests (§6.2 — MUST): Outbound capability queries were sent without the requirednodeattribute on<query>. Per spec, its value must be{caps-node}#{ver}for backwards-compatibility with legacy clients.Non-conforming data forms included in ver hash (§5.4 item 6):
getExtendedDataForms()included all<x xmlns='jabber:x:data'>forms unconditionally. Forms without aFORM_TYPEfield, or whereFORM_TYPEis nottype='hidden', must be ignored per spec — producing incorrect hashes for affected clients.No ill-formed response detection (§5.4 items 3–5):
isValid()only checked the hash. AddedisWellFormed()(called first) that rejects responses with duplicate identities, duplicate features, multiple forms sharing aFORM_TYPE, or aFORM_TYPEfield with conflicting values.Minor
@seeHTML anchor tags inEntityCapabilitiesManagerandEntityCapabilitiesListener.Tests
Added 6 targeted unit tests covering: ignored form without
FORM_TYPE, ignored form with non-hiddenFORM_TYPE, and all four ill-formed response rejection cases.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.