Fix XEP-0124 BOSH compliance: overactivity exception, ack handling, sentElements cleanup

[Copilot]

Openfire's BOSH implementation had several deviations from XEP-0124 around request acknowledgements, overactivity enforcement, and retransmission buffer management.

Changes

Overactivity check allows pause/terminate exception (§11)

Per spec, clients MAY send one additional simultaneous request if it is a pause or terminate. Previously the check fired at pendingConnections >= maxRequests unconditionally, rejecting valid pause/terminate requests from clients already at the limit.

// Before
if (pendingConnections >= maxRequests) { overactivity = TOO_MANY_SIM_REQS; }

// After — pause/terminate gets +1 headroom
final boolean isPauseOrTerminate = connection.isTerminate() || connection.getPause() != null;
final int maxSimultaneousRequests = isPauseOrTerminate ? maxRequests + 1 : maxRequests;
if (pendingConnections >= maxSimultaneousRequests) { overactivity = TOO_MANY_SIM_REQS; }

Parse client ack attribute from request bodies (§9.2)

Added HttpBindBody.getAck() to expose the client's acknowledged RID. When present, acknowledged entries are now pruned from the sentElements retransmission buffer rather than relying solely on a size cap of maxRequests.

Omit redundant ack in responses (§9.1)

"the connection manager SHOULD NOT include an 'ack' attribute in any response if the value would be the 'rid' of the request being responded to"

asBodyText() and createEmptyBody() now accept the responding-to RID and suppress the ack attribute when it would be identical—the common steady-state case.

Tests

Added HttpBindBodyTest covering getAck() (present/absent/invalid/initial-value), getRid(), and isPoll() variants.

---

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.