Skip to content

Conversation

@GenieTim
Copy link
Contributor

Closes #804; here, the output is determined by the corresponding parameter.

@GenieTim
Copy link
Contributor Author

The both option for the output will be requested in a separate PR that can be discussed individually, as it involves more than this function.

@szhorvat
Copy link
Member

I would suggest using simply min and max for the parameter names. This will be consistent with cliques(), https://python.igraph.org/en/stable/api/igraph.GraphBase.html#cliques, which is another function with lower and upper limits on the objects returned.

@szhorvat
Copy link
Member

@ntamas Could you please have a look at this when you get the time? This is very valuable functionality.

@szhorvat szhorvat force-pushed the simple-cycle-binding-v3 branch from 7f9a0f6 to 80e8c20 Compare March 22, 2025 09:46
@szhorvat
Copy link
Member

@ntamas Do you have any other concerns about this one (other than the comment I made above)?

@ntamas
Copy link
Member

ntamas commented Apr 1, 2025

@ntamas Do you have any other concerns about this one (other than the comment I made above)?

Nope, no other concerns, but what you pointed out needs to be addressed.

@szhorvat
Copy link
Member

szhorvat commented Apr 4, 2025

Shall we merge this?

@szhorvat szhorvat requested a review from ntamas April 4, 2025 15:27
@szhorvat szhorvat merged commit 8292280 into igraph:main Apr 10, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants