chore: autogenerate igraph_incident()
#2100
Conversation
Co-authored-by: Szabolcs Horvát <[email protected]>
|
Thank you @szhorvat, this is very helpful! |
| return result; | ||
| } | ||
|
|
||
| SEXP R_igraph_incident_edges(SEXP pgraph, SEXP pe, SEXP pmode) { |
There was a problem hiding this comment.
it seems I edited this wrong?!
There was a problem hiding this comment.
@szhorvat tagging you in case you see what curly brace I forgot 😅
There was a problem hiding this comment.
You only remove the first line of a function above.
| return result; | ||
| } | ||
|
|
||
| SEXP R_igraph_incident(SEXP graph, SEXP pvid, SEXP pmode) { |
There was a problem hiding this comment.
The problem is with this partial removal, not below.
Co-authored-by: Szabolcs Horvát <[email protected]>
tools/stimulus/functions-R.yaml
Outdated
|
|
||
| igraph_incident: | ||
| IGNORE: RR, RC | ||
| DEPS: vid ON graph |
There was a problem hiding this comment.
@szhorvat is this a DEPS that should be committed to the C library instead of here?
|
still getting error though, clearly I didn't get the changes in |
| res <- lapply(res, unsafe_create_es, graph = graph, es = E(graph)) | ||
| } | ||
|
|
||
| if (is_named(graph)) { |
There was a problem hiding this comment.
I need to move this into the yaml thus into aaa-auto.R
There was a problem hiding this comment.
@szhorvat I tried my best by looking at the YAML of functions with these lines:
if (igraph_opt("add.vertex.names") && is_named(graph)) {
names(res) <- vertex_attr(graph, "name", vids)
}but didn't manage to get it right.
part of work on "next" branch