Skip to content

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Sep 8, 2025

👋 @szhorvat! @schochastics and I would need your help to fix full_bipartite_impl(), which might need to happen in the configuration files for Stimulus that are stored in the C library.

The full_bipartite_impl() function has those lines:

rigraph/R/aaa-auto.R

Lines 336 to 338 in 0ef90cc

if (igraph_opt("add.vertex.names") && is_named(graph)) {
names(res$types) <- vertex_attr(graph, "name")
}

That are wrong (no graph exists) but also, I think, useless?

@maelle
Copy link
Contributor Author

maelle commented Sep 8, 2025

Note that I think it is useless because other functions with those lines take graph as an input whereas this function creates a new graph from scratch. So where would names come from?

@maelle
Copy link
Contributor Author

maelle commented Sep 8, 2025

The same problem exists for biadjacency_impl() (reference to a not existing graph object in the body):

rigraph/R/aaa-auto.R

Lines 2579 to 2581 in 0ef90cc

if (igraph_opt("add.vertex.names") && is_named(graph)) {
names(res$types) <- vertex_attr(graph, "name", V(graph))
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant