Use autogen-impl functions for 3 motifs functions #2152
+10
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
changed the title
maelle
commented
Sep 22, 2025
| #' count_motifs(g, 3) | ||
| #' sample_motifs(g, 3) | ||
| count_motifs <- function(graph, size = 3, cut.prob = NULL) { | ||
| ensure_igraph(graph) |
There was a problem hiding this comment.
I am on the fence about removing it, because even if that is asserted in the autogenerated function, shouldn't this happen before anything else?
There was a problem hiding this comment.
Could you be more specific? You mean remove the ensure_igraph() call? Maybe for consistency with other functions keep it still?
There was a problem hiding this comment.
@schochastics actually it's not very consistent among functions taking graph as input, from the little I've seen. A new upkeep task! 🤪
There was a problem hiding this comment.
I am actually not surprised 🙈
|
Other comments @schochastics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that these high-level functions are tested.