Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 26, 2025

  • Merge main branch
  • Remove on.exit(.Call(R_igraph_finalizer)) line (handled by _impl function)
  • Add experimental badge via r lifecycle::badge("experimental")
  • Add @concept hypercube for pkgdown reference index
  • Use named arguments in call to hypercube_impl()
  • Update documentation formatting
  • All tests pass (114 tests in test-make.R)
Original prompt

This section details on the original issue you should resolve

<issue_title>Add make_hypercube()</issue_title>
<issue_description>Expose igraph_hypercube(). Suggested R name: make_hypercube(). Don't forget to also add the corresponding hypercube(), which can be used with make_().

When writing docs, please pay attention to the phrasing zero-based vertex ID in the C docs. What's stated there is not true once IDs are shifted to be one-based.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add make_hypercube function to expose igraph_hypercube Add make_hypercube() Oct 26, 2025
Copilot AI requested a review from krlmlr October 26, 2025 13:35
Copilot finished work on behalf of krlmlr October 26, 2025 13:35
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot: Merge main and obey updated instructions.

Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot: Merge main and follow feedback and updated AGENTS.md .

R/make.R Outdated
#' print_all(make_hypercube(4))
#' @cdocs igraph_hypercube
make_hypercube <- function(n, directed = FALSE) {
on.exit(.Call(R_igraph_finalizer))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on.exit(.Call(R_igraph_finalizer))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the on.exit(.Call(R_igraph_finalizer)) line in cd7ad26. This is now handled by the autogenerated hypercube_impl() function, consistent with other recently added functions like make_circulant().

Copy link
Contributor Author

Copilot AI commented Nov 1, 2025

@copilot: Merge main and follow feedback and updated AGENTS.md .

Merged main and updated the implementation to follow the new guidelines in AGENTS.md in commit cd7ad26:

  • Removed on.exit(.Call(R_igraph_finalizer)) (handled by hypercube_impl)
  • Added experimental badge
  • Added @concept hypercube for pkgdown reference
  • Used named arguments in call to hypercube_impl()

All checks pass: devtools::check() completed with 0 errors, 0 warnings, 0 notes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cran.rstudio.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
  • packagemanager.posit.co
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from krlmlr November 1, 2025 11:34
Copilot finished work on behalf of krlmlr November 1, 2025 11:34
@krlmlr krlmlr marked this pull request as ready for review November 1, 2025 15:54
@krlmlr krlmlr requested a review from schochastics November 1, 2025 15:55
@krlmlr krlmlr removed their assignment Nov 1, 2025
@krlmlr
Copy link
Contributor

krlmlr commented Nov 1, 2025

@schochastics: When good, please merge this. Rough workflow:

  • I prompt and review
  • When good, I mark as ready, start tests, remove myself as an assignee and request a human review
  • When good and checks pass, squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add make_hypercube()

2 participants