Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the current state of adjusting to iiasa/ixmp4#219, which includes some changes and a big rewrite. It doesn't yet contain all changes that the shim layer requires and I'm running out of time, that's why the current state is not working properly. @meksor and/or @khaeru, I suspect it will be up to you to finish this.
Please note that I've imported various things
as <their old name>. This is just to see how much behaviour changes in the refactor, please feel free to adjust these imports so that the shim layer uses the new names once we're satisfied.How to review
PR checklist