Implemented Monolithic Architecture according to the guidelines provided by issue #2664 #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 3, 2024 10:45
…ructure, and added basic model files using H2 database since its light and efficient
…ructure, and added basic model files using H2 database since its light and efficient
…se to maintain code cleanliness
# Conflicts: # Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/Orders.java # Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/Products.java # Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/User.java
…asses and used the CLI main class from the previous submission and enhanced upon it
Added Detailed Readme File in the md format
Contributor
Author
|
I am aware of the 40% coverage i'll be adding more test cases and submitting another PR |
added 5 commits
December 7, 2024 09:10
added more test cases, and tried to fix pom.xml
iluwatar
requested changes
Dec 14, 2024
Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/EcommerceApp.java
Show resolved
Hide resolved
Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/controller/OrderCon.java
Outdated
Show resolved
Hide resolved
|
iluwatar
requested changes
Jan 11, 2025
monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/OrderCon.java
Outdated
Show resolved
Hide resolved
monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/Orders.java
Outdated
Show resolved
Hide resolved
PR SummaryThis PR implements a Monolithic Ecommerce application using an MVC structure, Spring Data JPA, and Mockito. It includes models for Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (18)
- 798e8dc: fixed naming and readme file
- be82b9c: Merge branch 'master' into master
- 21b083f: Merge branch 'Monolithic-Ecommerce'
- 5b03784: Fixes
Renamed the main module/directory. Added more content to the readme.md file. fixed the orElseThrow statements
Fixes
Renamed the main module/directory. Added more content to the readme.md file. fixed the orElseThrow statements
- 784d45e: added more test cases
- db565da: Merge branch 'Monolithic-Ecommerce'
- ef03a2c: another attempted fix
- c56393f: dropped change
- dc2c6a5: attempting to fix some debugging issues
added more test cases, and tried to fix pom.xml
- d5965a4: Readme File
Added Detailed Readme File in the md format
- b5b6c02: automatically generated puml
- e926e60: fixed testing class
- 31222a1: fixed checkstyle comments
- 2649ee8: added application.properties file for springboot, added controller classes and used the CLI main class from the previous submission and enhanced upon it
- 1c6c98b: Merge remote-tracking branch 'origin/master'
Conflicts:
Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/Orders.java
Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/Products.java
Monolithic-Ecommerce/src/main/java/com/iluwatar/monolithic/model/User.java
- d83632d: Added "controllers" and repository classes to communicate with database to maintain code cleanliness
- 916d683: added a pom.xml file for the monolithic structure, set up MVC file structure, and added basic model files using H2 database since its light and efficient
- 18be6b4: added a pom.xml file for the monolithic structure, set up MVC file structure, and added basic model files using H2 database since its light and efficient
Files Processed (20)
- monolithic-architecture/README.md (1 hunk)
- monolithic-architecture/etc/Monolithic-Ecommerce.urm.puml (1 hunk)
- monolithic-architecture/etc/monolithic-architecture.urm.puml (1 hunk)
- monolithic-architecture/pom.xml (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/EcommerceApp.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/OrderController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/ProductController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/UserController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/InsufficientStockException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/NonExistentProductException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/NonExistentUserException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/Order.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/Product.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/User.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/OrderRepository.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/ProductRepository.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/UserRepository.java (1 hunk)
- monolithic-architecture/src/main/resources/application.properties (1 hunk)
- monolithic-architecture/src/test/java/com/iluwatar/monolithic/MonolithicAppTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- dfbfc1e: Merge branch 'master' into master
Files Processed (20)
- monolithic-architecture/README.md (1 hunk)
- monolithic-architecture/etc/Monolithic-Ecommerce.urm.puml (1 hunk)
- monolithic-architecture/etc/monolithic-architecture.urm.puml (1 hunk)
- monolithic-architecture/pom.xml (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/EcommerceApp.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/OrderController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/ProductController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/controller/UserController.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/InsufficientStockException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/NonExistentProductException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/exceptions/NonExistentUserException.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/Order.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/Product.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/model/User.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/OrderRepository.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/ProductRepository.java (1 hunk)
- monolithic-architecture/src/main/java/com/iluwatar/monolithic/repository/UserRepository.java (1 hunk)
- monolithic-architecture/src/main/resources/application.properties (1 hunk)
- monolithic-architecture/src/test/java/com/iluwatar/monolithic/MonolithicAppTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (1)
-
monolithic-architecture/README.md [1-150]
best practice: "README.md formatting issues"
Skipped Comments (0)
iluwatar
approved these changes
Feb 15, 2025
|
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @MohanedAtef238 for code |
Contributor
|
I've put up a pull request to add @MohanedAtef238! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
this PR relates to issue #2664, it contains an example for the Monolithic Architecture using MVC file structure, it also builds upon the previously abandoned code and uses a couple of time saving utilities such as Spring Data JPA and Mockito.