Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the avifo (AVIF options) option, which allows redefining AVIF saving options, specifically controlling when chroma subsampling is applied to AVIF images.
- Implements the
avifooption with support for both string and object notation - Adds complete type definitions for AVIF subsample options (
auto,on,off) - Provides comprehensive test coverage for all use cases including validation and error handling
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/avifOptions.ts | Defines TypeScript types for AVIF options with support for both shorthand string and object notation with subsample property |
| src/options/avifOptions.ts | Implements the test and build functions for the avifo option, including validation logic |
| tests/optionsBasic/avifOptions.test.ts | Comprehensive test suite covering string/object notation, aliases, validation, and error handling |
| src/types/index.ts | Integrates AvifOptionsPartial into the main Options type |
| src/options/index.ts | Exports the avifOptions module |
| .changeset/small-views-battle.md | Documents the new feature for the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67