Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the flip option to imgproxy-js-core, allowing users to flip images horizontally and/or vertically. The implementation follows the established patterns used by other boolean-like options in the codebase.
Key Changes:
- Adds flip option type definitions with support for boolean-like values (
true,false,1,0,"t","f") - Implements flip option builder that generates the
fl:horizontal:verticalURL format - Includes comprehensive test coverage for various value types and edge cases
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/types/flip.ts |
Defines FlipOptions type and FlipOptionsPartial interface with horizontal/vertical properties supporting boolean-like values |
src/options/flip.ts |
Implements test and build functions for flip option, including shorthand fl support |
tests/optionsBasic/flip.test.ts |
Comprehensive test suite covering various input types, defaults, and both flip/fl shorthands |
src/types/index.ts |
Integrates FlipOptionsPartial into the main Options type |
src/options/index.ts |
Exports flip module for public API access |
.changeset/brown-mangos-fetch.md |
Documents the feature addition as a minor version change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66