Skip to content

Conversation

midzelis
Copy link
Collaborator

@midzelis midzelis commented Oct 6, 2025

Refactor shortcuts to use new {@attach} syntax and enhance shortcuts handling:

  • Cleaner syntax with fewer nested objects
  • Better ergonomics with union type support and helper functions
  • Integrated help system with automatic modal registration
  • Scoping support for hierarchical shortcut management
  • Categorization for better organization
  • Variant pairing for related shortcuts
  • Platform awareness for displaying appropriate key symbols

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Deploying preview environment to https://pr-22689.preview.internal.immich.cloud/

@midzelis midzelis force-pushed the feat/keyboard_actions_help_modal branch 2 times, most recently from 852526c to 0bcb5a7 Compare October 7, 2025 01:27
@alextran1502
Copy link
Member

alextran1502 commented Oct 7, 2025

Thanks, Min, for the nice PR, I did some testing and have some feedback

  1. When on the /photos route, pressing ctrl + t will open the tag model AND switch the light/dark mode
  2. In dark mode, the key combination doesn't have a background,
image image
  1. While on the timeline, pressing action such as "Shift + A" will still trigger the archive action, is this expected?

Other than that, great work! When you are done addressing the issue above, I can help with some minor styling tweaks

@midzelis midzelis force-pushed the feat/keyboard_actions_help_modal branch from 0bcb5a7 to 8ddc299 Compare October 8, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants