Skip to content

Conversation

idubnori
Copy link
Contributor

@idubnori idubnori commented Oct 7, 2025

Description

Feature

  • new activity : "added assets to album". in this PR, web only
    • If multiple assets are added, show first one thumb and as "+N" string
    • Assets added within the last 15 minutes will be one activity row
    • If remove asset from album, "+N" string is decreased. removed all, remove the activity row

schema / database changes

  • added "assetIds" column into activity table
  • added new db trigger remove asset id from assetIds when remove asset from album

API Changes ( /activities )

  • added new reaction type "Asset"
  • added "assetIds" field into activity dtos

Fixes # (issue)

  • N/A

How Has This Been Tested?

Manually

  • new activity : "added assets to album", in this PR, web only
    • If multiple assets are added, show first one thumb and as "+N" string
    • Assets added within the last 15 minutes will be one activity row
    • If remove asset from album, "+N" string is decreased. removed all, remove the activity row

Unit tests

  • adjusted / added activity.service tests

E2E tests

  • added asset activity tests into activity.e2e-spec

Screenshots (if appropriate)

test2_-_Immich_と_immich-app_main___idubnori_work_nori_activity-album-update-1_·_immich-app_immich_を比較しています image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

  • server: Initial implementation and more
  • web: almost

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web, 🗄️server. A maintainer will add the required label.

@idubnori idubnori closed this Oct 7, 2025
@idubnori idubnori reopened this Oct 7, 2025
@idubnori idubnori marked this pull request as draft October 7, 2025 16:31
@idubnori idubnori force-pushed the work/nori/activity-album-update-1 branch from 7be8943 to e635363 Compare October 8, 2025 08:13
@idubnori idubnori force-pushed the work/nori/activity-album-update-1 branch from e635363 to 62b6363 Compare October 8, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant