-
Notifications
You must be signed in to change notification settings - Fork 16
chore: update game bridge to 2.12.6 #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
platform-sa
wants to merge
11
commits into
main
Choose a base branch
from
chore/update-game-bridge-2.12.6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,179
−361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
reviewed
Feb 4, 2026
92a1033 to
b6ba396
Compare
nattb8
reviewed
Feb 4, 2026
| time.sleep(5) | ||
| print("Logged out") | ||
|
|
||
| self.altdriver.stop() |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep logout and wait for authenticated screen so that we test logout too
b6ba396 to
7ea6a56
Compare
08a7b92 to
7e7bc50
Compare
…bility Add controlled browser logout for macOS to handle deep-link dispatch issues introduced by Chrome 137 code-splitting changes. Changes: - Add logout_with_controlled_browser() in test_mac_helpers.py - Add get_logout_url_from_unity_logs() to monitor Unity logs - Add get_product_name() to extract product name from ProjectSettings - Update logout() method to use controlled browser approach - Manually trigger immutablerunner://logout deep-link via 'open' command - Reduce Windows login timeout from 90s to 30s This matches the Windows implementation and resolves logout timeouts caused by Chrome 137's increased code-splitting affecting protocol handler reliability.
7e7bc50 to
dc755d5
Compare
Windows: - Extract returnTo deep-link from logout URL - Write deep-link to Windows Registry for Unity to process - Fixes app crash by ensuring logout callback is received macOS: - Kill existing Brave processes before launching with debugging port - Prevents 'cannot connect to chrome at localhost:9222' error - Ensures controlled logout can connect to browser Both platforms now properly dispatch immutablerunner://logout deep-link back to Unity after browser logout completes.
6041098 to
1b391d9
Compare
Extract tab closing logic into reusable methods: - Windows: close_all_browser_tabs() in test_windows_helpers.py - macOS: close_all_browser_tabs() method in MacTest class Call in setUpClass to ensure clean browser state before test suite runs. This prevents leftover tabs from previous runs from interfering with tests. Also refactor stop_browser() to use the new tab closing methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update game bridge (build from ts-immutable-sdk version 2.12.6)