Skip to content

Vertical hover overlay follow-up + remove sidebar tab-search button#1004

Closed
dusan-nikcevic wants to merge 6 commits intoimputnet:mainfrom
dusan-nikcevic:plan/vertical-tabs-hover-overlay
Closed

Vertical hover overlay follow-up + remove sidebar tab-search button#1004
dusan-nikcevic wants to merge 6 commits intoimputnet:mainfrom
dusan-nikcevic:plan/vertical-tabs-hover-overlay

Conversation

@dusan-nikcevic
Copy link

@dusan-nikcevic dusan-nikcevic commented Feb 26, 2026

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented
    (an approved feature request, or confirmed bug).
  • I tested that my contribution works locally, and does not break anything,
    otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this
    organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

  • Windows
  • macOS
  • Linux

Follow-up to #964 for approved issue #915 (vertical tabs hover expand):

  • Keep collapsed vertical tabs reserved width stable while drawing hover expansion as overlay.
  • Wire hover enter/exit and hover-expand state through vertical tab strip layout callers.
  • Add smooth hover expand/collapse animation path (avoid jumpy size changes).
  • Add command + settings pref plumbing for collapse/hover behavior.
  • Remove persistent vertical tab-search sidebar button from layout (no top-left search icon in vertical sidebar).
  • Add two upstream-compat build patches that unbreak current tree compilation:
    • autofill-async-context-model-predictions.patch
    • passage-embeddings-forward-decl.patch

Local validation:

  • python3 ./devutils/lint.py passes.
  • ninja -C out/DevFast chrome succeeds in local Chromium worktree.
  • Manual runtime verification on Linux with DevFast build and vertical tabs enabled.

Example:

2026-02-27.00-12-54.online-video-cutter.com.mp4

@dusan-nikcevic dusan-nikcevic changed the title helium/ui/layout: vertical hover overlay follow-up + remove sidebar tab-search button Vertical hover overlay follow-up + remove sidebar tab-search button Feb 27, 2026
@quanticstudios
Copy link

Moved this work to from quanticstudios fork. Keeping this open briefly for reviewer continuity.

@quanticstudios
Copy link

Correct link: moved this work to #1014 from quanticstudios fork. Keeping this PR open briefly for reviewer continuity.

@dusan-nikcevic dusan-nikcevic deleted the plan/vertical-tabs-hover-overlay branch February 28, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants