feat(search): add Brave Search as prepopulated engine#724
Closed
R0h1tAnand wants to merge 1 commit intoimputnet:mainfrom
Closed
feat(search): add Brave Search as prepopulated engine#724R0h1tAnand wants to merge 1 commit intoimputnet:mainfrom
R0h1tAnand wants to merge 1 commit intoimputnet:mainfrom
Conversation
Add Brave Search (search.brave.com) as an out-of-the-box search engine option. - Add brave_search engine definition to prepopulated_engines.json - Include Brave Search in default search engines list (regional_settings.json) - Place Brave Search at the top of the engine list for visibility Fixes: imputnet#92
There was a problem hiding this comment.
Pull request overview
This PR adds Brave Search (search.brave.com) as a prepopulated search engine option available out-of-the-box.
- Introduces a new engine definition for Brave Search in the prepopulated engines configuration
- Adds Brave Search to the default regional search engines list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| patches/series | Adds the new add-brave-search.patch to the patch application sequence |
| patches/helium/core/search/add-brave-search.patch | Defines the Brave Search engine configuration with search and suggestion URLs, and includes it in the default regional search engines list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
This is a duplicate of #276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
If such issue did not exist before, I opened one.
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
Add Brave Search (search.brave.com) as an out-of-the-box search engine option.
Changes:
brave_searchengine definition toprepopulated_engines.jsonregional_settings.json)Fixes #92